Warning: htmlspecialchars() expects parameter 1 to be string, array given in check_plain() (line 1571 of /includes/bootstrap.inc).

This is caused because it get's an array from site_map_show_menus

CommentFileSizeAuthor
#2 variables-2607604-2.patch3.46 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new variables-2607604-2.patch3.46 KB

Moved to the site_map.variable.inc folder also because it get's auto loaded.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good.

I tested the patch this way:

  1. Went to the variable admin page (admin/config/system/variable). The reported php warning is no longer there, this is good.
  2. I went to admin/config/system/variable/edit/site_map_show_menus and I checked if could edit the 'site_map_show_menus' variable properly and this was the case: changing a value got saved.
  3. I looked inside the variable_variable_type_info() function of the variable module to confirm if the type "array" is the right choice for the variable and it appears it is. I did try if the type "options" would fit better (because ideally the edit form for the variable would show as checkboxes instead of a serie of text fields), but that made the variable to be no longer editable, so "array" is the right choice here.

RTBC.

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib

Hi people.

Really looks good.

Thank you very much for contributions.

Good Work and Good Weekend.

Regards.

  • RenatoG committed c7c5ba0 on 7.x-1.x authored by joelpittet 
    Issue #2607604 by joelpittet, MegaChriz, RenatoG: Variables '...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thank you very much people.

Good Work and Good Weekend.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.