Why is this RC eligible

Because it only changes docs.

As far as I can tell, since site branding was moved into block--system-branding-block.html.twig, the site branding variables site_name, site_slogan and logo are no longer available to use in page.html.twig. However, they are still included in the docblock in the core page.html.twig and each of the three core themes that override it (classy, bartik and seven).

Unless I've missed something and these variables can still be accessed from these templates, I would like to remove the references to them from the docblock text to avoid confusion.

Comments

mangy.fox created an issue. See original summary.

mangy.fox’s picture

Here's a quick patch to remove the old variables from the docblock.

Cottser’s picture

Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
Issue tags: +rc eligible, +documentation, +Twig

Thanks!

joelpittet’s picture

Status: Needs review » Needs work

This looks fine, just needs to be removed from Stable as well now.

mangy.fox’s picture

Now also corrected for new Stable theme.

Cottser’s picture

Status: Needs work » Needs review

Thanks.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

Perfecto thank you.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: drupal-8.x-page_variable_doc-2607508-5.patch, failed testing.

mangy.fox’s picture

Not sure why this failed, re-testing for sanity check.

The last submitted patch, 5: drupal-8.x-page_variable_doc-2607508-5.patch, failed testing.

Cottser’s picture

Status: Needs work » Reviewed & tested by the community

We had some random fails on HEAD.

  • xjm committed eb627bd on 8.1.x
    Issue #2607508 by mangy.fox, joelpittet: Incorrect site branding...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.1.x and 8.0.x. Thanks!

  • xjm committed 7a09591 on 8.0.x
    Issue #2607508 by mangy.fox, joelpittet: Incorrect site branding...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.