Why is this RC eligible
Because it only changes docs.
As far as I can tell, since site branding was moved into block--system-branding-block.html.twig, the site branding variables site_name, site_slogan and logo are no longer available to use in page.html.twig. However, they are still included in the docblock in the core page.html.twig and each of the three core themes that override it (classy, bartik and seven).
Unless I've missed something and these variables can still be accessed from these templates, I would like to remove the references to them from the docblock text to avoid confusion.
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal-8.x-page_variable_doc-2607508-5.patch | 4.58 KB | mangy.fox |
#2 | drupal-8.x-page_variable_doc-2607508-1.patch | 3.66 KB | mangy.fox |
Comments
Comment #2
mangy.fox CreditAttribution: mangy.fox at Investis Digital commentedHere's a quick patch to remove the old variables from the docblock.
Comment #3
star-szrThanks!
Comment #4
joelpittetThis looks fine, just needs to be removed from Stable as well now.
Comment #5
mangy.fox CreditAttribution: mangy.fox at Investis Digital commentedNow also corrected for new Stable theme.
Comment #6
star-szrThanks.
Comment #7
joelpittetPerfecto thank you.
Comment #9
mangy.fox CreditAttribution: mangy.fox at Investis Digital commentedNot sure why this failed, re-testing for sanity check.
Comment #11
star-szrWe had some random fails on HEAD.
Comment #13
xjmCommitted and pushed to 8.1.x and 8.0.x. Thanks!