Hey,

thanks a lot for porting this to D8. This module is essential for many REST applications.

Found a small bug while changing url options. Currently, only the full url option works as intended with both relative and absolute options rendering the full url.

CommentFileSizeAuthor
#6 2606100-6.patch1.22 KBshubham.prakash
#2 image_url_formatter-fix-relative-absolute-2606100-2-8.patch1.62 KBswim

Comments

swim created an issue. See original summary.

swim’s picture

swim commented
Status: Active » Needs review
StatusFileSize
new image_url_formatter-fix-relative-absolute-2606100-2-8.patch1.62 KB

Please find patch attached.

  • g089h515r806 committed 2357a29 on 8.x-1.x authored by swim 
    Issue #2606100 by swim: Formatter only provides full url option
krlucas’s picture

krlucas commented
Status: Needs review » Reviewed & tested by the community

Tested on 8.x-1.x branch.
Full, absolute, and relative all appear to be working as intended.

axe312’s picture

axe312 commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Tests? 

+++ b/image_url_formatter.module
@@ -37,7 +37,7 @@ function image_url_formatter_theme() {
+  // drupal_set_message(var_export($item,true));

why are you not removing this?

Also this is a pretty much a main feature I expect to work always for this module. We should add some simple tests :)

shubham.prakash’s picture

shubham.prakash commented
Status: Needs work » Needs review
StatusFileSize
new 2606100-6.patch1.22 KB

Shouldn't the other commented lines of "drupal_set_message" also be removed?

g089h515r806’s picture

g089h515r806 commented
Status: Needs review » Fixed

the //drupal_set_message code removed in other commit, I use it debug the code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.