Problem/Motivation

For no reason #2605684: Routing silently fails in kernel tests does not include a fix for \Drupal\KernelTests\KernelTestBase,
let's port that

Proposed resolution

Port it over.

Remaining tasks

Figure out whether a) is the TestServiceProvider used b) is the simpletest namespace available at all. One possible place to put similar changes is in \Drupal\KernelTests\KernelTestBase::register.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 2605956_12.patch4.04 KBchx
#11 interdiff.txt623 bytesdawehner
#11 2605956-11.patch2.69 KBdawehner
#7 interdiff.txt2.65 KBdawehner
#7 2605956-7.patch2.65 KBdawehner
#5 interdiff.txt1.41 KBdawehner
#5 2605956-5.patch4.41 KBdawehner
#3 2605956-3.patch4.07 KBdawehner

Comments

dawehner created an issue. See original summary.

chx’s picture

chx commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented
Title: Port #2605684 to the current KernelTestBase » Remove #2605684 again
Version: 8.0.x-dev » 8.1.x-dev
Status: Active » Needs review
StatusFileSize
new 2605956-3.patch4.07 KB

Let's consider this no longer as needed, but let's repurpose the issue to remove the layer again for 8.1.x

Status: Needs review » Needs work

The last submitted patch, 3: 2605956-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2605956-5.patch4.41 KB
new interdiff.txt1.41 KB

Ups

Status: Needs review » Needs work

The last submitted patch, 5: 2605956-5.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2605956-7.patch2.65 KB
new interdiff.txt2.65 KB

This was BS

chx’s picture

chx commented

Why remove?

dawehner’s picture

dawehner
Primary language German
commented
Title: Remove #2605684 again » Port #2605684 to the new KernelTest

For whatever reason I thought its not longer needed, but #7 actually ports it.

chx’s picture

chx commented
Status: Needs review » Needs work

catch dislikes naked @todo please file an issue and reference it. Thanks!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2605956-11.patch2.69 KB
new interdiff.txt623 bytes
chx’s picture

chx commented
StatusFileSize
new 2605956_12.patch4.04 KB

I would rather do this. Also, given

use Drupal\simpletest\AssertContentTrait;
use Drupal\simpletest\AssertHelperTrait;
use Drupal\simpletest\RandomGeneratorTrait;

are you sure we need that @todo?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Alright. Thank you chx

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
error: patch failed: core/modules/simpletest/src/RouteProvider.php:13
error: core/modules/simpletest/src/RouteProvider.php: patch does not apply
error: patch failed: core/modules/simpletest/src/TestServiceProvider.php:33
error: core/modules/simpletest/src/TestServiceProvider.php: patch does not apply
error: patch failed: core/tests/Drupal/KernelTests/Core/Entity/RouteProviderTest.php:37
error: core/tests/Drupal/KernelTests/Core/Entity/RouteProviderTest.php: patch does not apply
error: patch failed: core/tests/Drupal/KernelTests/KernelTestBase.php:25
error: core/tests/Drupal/KernelTests/KernelTestBase.php: patch does not apply
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Fixed

This method was already committed as part of #2684095: Convert field kernel tests to KernelTestBaseTNG

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Fixed » Closed (duplicate)
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#2684095: Convert field kernel tests to KernelTestBaseTNG