Convert field kernel tests to KernelTestBaseTNG

1. --- a/core/modules/comment/src/Tests/CommentItemTest.php
   +++ b/core/modules/comment/src/Tests/CommentItemTest.php
   
   --- a/core/modules/datetime/src/Tests/DateTimeItemTest.php
   +++ b/core/modules/datetime/src/Tests/DateTimeItemTest.php
   

   These two are missing a rename and a namespace change.

2. +++ b/core/modules/field/tests/src/Kernel/FieldImportChangeTest.php
   @@ -20,7 +21,7 @@ class FieldImportChangeTest extends FieldUnitTestBase {
   +   * \Drupal\Tests\field\Kernel\FieldUnitTestBase::setUp() when it installs field
       * configuration.
   

   This comment needs to be re-wrapped to 80 cols.

3. +++ b/core/modules/field/tests/src/Kernel/FieldImportCreateTest.php
   @@ -97,8 +97,8 @@ function testImportCreate() {
   -    $target_dir = $this->configDirectories[CONFIG_SYNC_DIRECTORY];
   ...
   +    $target_dir = config_get_config_directory(CONFIG_SYNC_DIRECTORY);
   

   \Drupal\simpletest\KernelTestBase::prepareConfigDirectories() was doing a bunch of things, including a sanity check that the config directory exists and is writable.

   We don't need that anymore with the phpunit-based test class?

4. +++ b/core/modules/field/tests/src/Kernel/FieldImportDeleteTest.php
   @@ -22,7 +23,7 @@ class FieldImportDeleteTest extends FieldUnitTestBase {
   +   * \Drupal\Tests\field\Kernel\FieldUnitTestBase::setUp() when it installs field
       * configuration.
   

   Another one :)

5. +++ b/core/modules/field/tests/src/Kernel/FieldUnitTestBase.php
   @@ -2,17 +2,17 @@
   - * Contains \Drupal\field\Tests\FieldUnitTestBase.
   + * Contains \Drupal\Tests\field\Kernel\FieldUnitTestBase.
   

   Shouldn't this be called FieldKernelTestBase?

6. +++ b/core/modules/field/tests/src/Kernel/FieldValidationTest.php
   @@ -2,10 +2,11 @@
   +namespace Drupal\Tests\field\Kernel;
   +use Drupal\Tests\field\Kernel\FieldUnitTestBase;
   

   Missing empty line.

7. +++ b/core/modules/field/tests/src/Kernel/FormatterPluginManagerTest.php
   @@ -2,12 +2,13 @@
   +namespace Drupal\Tests\field\Kernel;
    use Drupal\Core\Field\BaseFieldDefinition;
   

   Same here.

8. +++ b/core/modules/field/tests/src/Kernel/TranslationTest.php
   @@ -193,7 +194,7 @@ function testTranslatableFieldSaveLoad() {
   -        $this->assertEqual($entity->getTranslation($langcode)->{$field_name_default}->getValue(), $empty_items, format_string('Empty value correctly populated for language %language.', array('%language' => $langcode)));
   +        $this->assertEquals([], $entity->getTranslation($langcode)->{$field_name_default}->getValue(), format_string('Empty value correctly populated for language %language.', array('%language' => $langcode)));
   

   $empty_items can also be NULL, why are we dropping that assertion?

9. --- a/core/modules/file/src/Tests/FileItemTest.php
   +++ b/core/modules/file/src/Tests/FileItemTest.php
   
   --- a/core/modules/image/src/Tests/ImageItemTest.php
   +++ b/core/modules/image/src/Tests/ImageItemTest.php
   
   --- a/core/modules/link/src/Tests/LinkItemTest.php
   +++ b/core/modules/link/src/Tests/LinkItemTest.php
   
   --- a/core/modules/options/src/Tests/OptionsFieldUnitTestBase.php
   +++ b/core/modules/options/src/Tests/OptionsFieldUnitTestBase.php
   
   +++ b/core/modules/options/src/Tests/OptionsFieldUnitTestBase.php
   @@ -8,13 +8,13 @@
   +abstract class OptionsFieldUnitTestBase extends \Drupal\Tests\field\Kernel\FieldUnitTestBase {
   
   --- a/core/modules/rdf/src/Tests/Field/FieldRdfaTestBase.php
   +++ b/core/modules/rdf/src/Tests/Field/FieldRdfaTestBase.php
   
   --- a/core/modules/telephone/src/Tests/TelephoneItemTest.php
   +++ b/core/modules/telephone/src/Tests/TelephoneItemTest.php
   
   --- a/core/modules/text/src/Tests/TextWithSummaryItemTest.php
   +++ b/core/modules/text/src/Tests/TextWithSummaryItemTest.php
   

   Missing file move and namespace update.

10. +++ b/core/modules/rdf/src/Tests/Field/FieldRdfaTestBase.php
    @@ -45,7 +45,7 @@
    -  protected $debug = TRUE;
    +  protected $debug = FALSE;
    

    Any reason for this change?

Well, phpstorm doesn't allow one to provide logging like that by default ...

I think you mean phpunit, not phpstorm :) And that's a shame really, maybe we should try to add some debugging helpers in our base test classes or, why not, directly upstream. But certainly not in this issue.

The patch looks good to me now, let's hope the testbot agrees.

Committed c2f6eb6 and pushed to 8.1.x. Thanks!