Problem/Motivation

Fieldblocks won't be displayed when viewing a revision of a entity or during preview mode when viewing a node entity.

Proposed resolution

Refactor \Drupal\fieldblock\Plugin\Block\FieldBlock so it also takes entity revision/preview routes into account.

Remaining tasks

None

User interface changes

Fieldblocks will be displayed on entity revision/preview routes.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#8 fieldblock_display_revision_2605874_8.patch4.07 KBnkoporec
#6 interdiff-2605874-2-6.txt709 bytesdpacassi
#6 fieldblocks_on_entity_revisions-2605874-6.patch3.76 KBdpacassi
#2 2605874.patch3.68 KBcasey

Comments

casey created an issue. See original summary.

casey’s picture

casey commented
StatusFileSize
new 2605874.patch3.68 KB
casey’s picture

casey commented
Status: Active » Needs review
casey’s picture

casey commented
Assigned: casey » Unassigned
dpacassi’s picture

dpacassi
Primary language English
Location Zürich, Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch, still works with fieldblock 2.0 alpha1 and Drupal 8.4.2.

dpacassi’s picture

dpacassi
Primary language English
Location Zürich, Switzerland
commented
StatusFileSize
new fieldblocks_on_entity_revisions-2605874-6.patch3.76 KB
new interdiff-2605874-2-6.txt709 bytes

I've had to adapt the patch slightly as it didn't work for "node/nid/latest" urls.
Attached is an updated patch (also updated to work with the dev branch) as well as the interdiff.

sutharsan’s picture

sutharsan commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs reroll, Patch does not apply.

+++ b/src/Plugin/Block/FieldBlock.php
@@ -377,8 +377,10 @@
+      $is_latest_route = $route_name == 'entity.node.latest_version';

This should also be entity type independent.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review
StatusFileSize
new fieldblock_display_revision_2605874_8.patch4.07 KB

Created a patch re-roll with fixed issue that @Sutharsan raised.

keshavv’s picture

keshavv commented

I tested the patch, #8 will fix the problem. thanks

sutharsan’s picture

sutharsan commented

@nkoporec, thanks for the re-roll. Next time please make a separate patch for re-roll and for the change. That way you can provide an interdiff of only the changes which makes it easier to check what you have done. And gives me more confidence that the re-roll does not contain changes.

sutharsan’s picture

sutharsan commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

  • Sutharsan committed 85d12a0 on 8.x-2.x authored by nkoporec 
    Issue #2605874 by dpacassi, casey, nkoporec: Display fieldblocks on...
sutharsan’s picture

sutharsan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.