When a user tries to subscribe/unsubscribe to any node not associated with taxonomy terms, a PHP error is thrown reg. the illegal foreach loop.

CommentFileSizeAuthor
#3 total_subscription-nodes-without-tids-issue-2605306-3-7.41.patch899 bytesjazzitup
#2 total_subscription-nodes-without-tids-issue-2605306-1-7.41.patch1.55 KBjazzitup

Comments

jazzitup created an issue. See original summary.

jazzitup’s picture

jazzitup commented
Status: Active » Needs review
StatusFileSize
new total_subscription-nodes-without-tids-issue-2605306-1-7.41.patch1.55 KB

This patch should fix it.

jazzitup’s picture

jazzitup commented
StatusFileSize
new total_subscription-nodes-without-tids-issue-2605306-3-7.41.patch899 bytes

Fixing a patch by removing changes from the previous patch. :)

deepakaryan1988’s picture

deepakaryan1988
Primary language Hindi
commented

Thanks @jazzitup for this patch.
I will review it and merge it. :)

jazzitup’s picture

jazzitup commented

Great! I've spotted those PHP errors on those two lines of code, but I probably missed a few other spots (that would be triggered in some other/similar scenario).

deepakaryan1988’s picture

deepakaryan1988
Primary language Hindi
commented
Status: Needs review » Fixed

Merged with dev branch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.