The issue is that when user has more then one page of space notifications settings, saving settings on one page reverts settings on all other pages to default - the cause is simple, the submit handler does not take already saved values into account and simply saves the new values only.

My patch here fixes the issue.

CommentFileSizeAuthor
#2 oa_core-notifications-settings-2604960-1.patch788 bytesm1n0

Comments

m1n0 created an issue. See original summary.

m1n0’s picture

m1n0 commented
Status: Active » Needs review
StatusFileSize
new oa_core-notifications-settings-2604960-1.patch788 bytes
mpotter’s picture

mpotter commented
Status: Needs review » Fixed

Thanks for this! Works great and actually helped me find a bug with the pager where it was caching and not showing the pager sometimes. Did the pager fix in oa_core commit cb97e78. Committed the patch in #2 to f60b5b9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.