in file : /core/lib/Drupal/Core/Field/BaseFieldDefinition.php

There is comment typo, following is the changes.

   */
   public function setSettings(array $settings) {
-    // Assign settings individiually, in order to keep the current values
+    // Assign settings individually, in order to keep the current values
     // of settings not specified in $settings.
CommentFileSizeAuthor
typo-incomment-1.patch724 bytesrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix, +rc eligible

Thanks!

  • xjm committed 9fc4d2e on 8.0.x 
    Issue #2604722 by rakesh.gectcr: Comment typo in BaseFieldDefinition.php...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#2383863: Spellchecking Drupal - Comments

We had a initiative to spellcheck core awhile ago -- #2383863: Spellchecking Drupal - Comments. This makes me think about the feasibility of having spellchecking for comments in our coding standards testing, but my thought is that there would be just far too many special terms not found in a spellchecker. So I didn't add anything about that to #2571965: [meta] Fix PHP coding standards in core, stage 1.

Thanks @rakesh.gectcr for all your work fixing coding standards bugs in core! If you find further simple spelling errors in core comments, please combine the fixes into one patch (if the patch will be smaller than 50K or so), since simple spelling errors are easy to review with git diff --color-words.

Committed and pushed to 8.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.