Closed (fixed)
Project:
Search API Solr
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
29 Oct 2015 at 16:00 UTC
Updated:
4 Mar 2020 at 22:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lex0r commentedPossible implementation attached.
Comment #3
drunken monkeyGreat idea, thanks! That could really help a lot of people debugging their problems. Really strange that no-one thought of this before …
There are just a few small problems with your patch, but other than that it already looks great:
Here and in other places: please surround the array access with
!empty(), otherwise people will receive PHP notices after upgrading, before re-saving the server.This needs a clean-up regarding the Drupal documentation standards.
In any case, thanks again for creating this issue!
Comment #4
lex0r commentedHi @drunken-monkey,
please review the patch. Besides the fixes now it also logs facets (if the case).
Comment #5
lex0r commentedComment #6
drunken monkeyLooks good, thanks!
However, I now noted that
watchdog()is used in a not-recommended way. I also rephrased the form field descriptions and had some other style cleanup. Please test/review and I can commit!Comment #7
lex0r commentedI tested it locally and it works well.
Comment #8
drunken monkeyOK, committed.
Moving to D8 for porting.
Thanks again!
Comment #10
janusman commentedJust thought I'd mention solr_devel module... although that module currently shows a request in a block instead of logging it to watchdog.
Comment #11
mkalkbrennerComment #12
mkalkbrennerComment #14
mkalkbrennerComment #16
josephdpurcell commentedComment #17
josephdpurcell commentedComment #18
josephdpurcell commentedIn case anyone else lands here, it's worth noting there is some documentation here: https://www.drupal.org/node/2240049. It includes a robust example of logging using Solarium events.