commerce_product_handler_field_product_link does not use entity_uri()

+++ b/modules/product/includes/views/handlers/commerce_product_handler_field_product_link.inc
@@ -3,7 +3,7 @@
+class commerce_product_handler_field_product_link extends views_handler_field_url {

@@ -33,10 +33,18 @@ class commerce_product_handler_field_product_link extends views_handler_field {
-    return l($text, 'admin/commerce/products/' . $product_id);
+    return url($uri['path'], $uri['options']);

I could be wrong but shouldn't this be a new handler called commerce_product_handler_field_product_url? Before it was returning a link tag and now it's returning a URL. Something is not fitting.

+++ b/modules/product/includes/views/handlers/commerce_product_handler_field_product_link.inc
@@ -33,10 +33,18 @@ class commerce_product_handler_field_product_link extends views_handler_field {
+  function get_value($values, $field = NULL) {

Changed from render to get_value, because views_handler_field_url renders a link.

  /**
   * Render the field.
   *
   * @param $values
   *   The values retrieved from the database.
   */
  public function render($values) {
    return EntityFieldHandlerHelper::render($this, $values);
  }

Drills into

  public static function render_entity_link($handler, $value, $values) {
    // Allow easy overriding of this behaviour in the specific field handler.
    if (method_exists($handler, 'render_entity_link')) {
      return $handler->render_entity_link($value, $values);
    }
    $render = self::render_single_value($handler, $value, $values);
    if (!$handler->options['link_to_entity']) {
      return $render;
    }
    $entity = $handler->get_value($values, 'entity object');
    if (is_object($entity) && ($url = entity_uri($handler->entity_type, $entity))) {
      return l($render, $url['path'], array('html' => TRUE) + $url['options']);
    }
    return $render;
  }

Now it uses Entity API to properly render link

Xano, I moved it back to CNR for your patch as it's proper in my opinion.

@mglaman if views_handler_field_url renders a link, and this is being changed to use that class, shouldn't this also render a link as it did before then? Either the name is really confusing or I am missing something...

To clarify my concern the render() to get_value() override looks fine, my only concern is the confusing class name.

Maybe we can't do anything about that but yeah...