CommentFileSizeAuthor
#2 2604038.patch647 bytesheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Active » Needs review
StatusFileSize
new 2604038.patch647 bytes
goldlilys’s picture

goldlilys commented

If it's only being used once in the code overall, no need to declare extra variable. It works for me in Simplytest.me using drupal 8.1.x too without errors.

PS: newbie contributor and not sure how else to review the code ... any guidance is appreciated.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

So yeah while I think this can totally land at any point, given that it doesn't break any BC layer, IMHO we don't need this before the release, but we could totally commit this for 8.0.1

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2604038.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed a4f5b2d on 8.1.x 
    Issue #2604038 by heykarthikwithu: Views module's "base.js" function "...

  • catch committed 552f263 on 
    Issue #2604038 by heykarthikwithu: Views module's "base.js" function "...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript
droplet’s picture

droplet commented

There're a lot of these kind of redundant code in Ckeditor/Editor modules. If someone interested, you can take a look at that.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu

Sure, will take and work on this :)

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

#2625512: Add @param, @return in the code base for the editor module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned