Hey there,
I tried to recreate a feature in the backend.
Since I do not have the permission to "generate features" I did not have the option to "generate" the feature.
Due to this a PHP notice occurred on submit.
Notice: Undefined index: generate in features_export_build_form_submit() (line 868 of /path/to/drupal/sites/all/modules/contrib/features/features.admin.inc).
I have fixed that and two little coding standard failures in line endings in the features.admin.inc.
Patch will be up in the second comment.
func0der
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | php_notice_during-2603308-15.patch | 713 bytes | alesr |
Comments
Comment #2
func0der commentedComment #3
func0der commentedComment #5
func0der commentedWrong paths, sorry.
Comment #6
func0der commentedComment #8
func0der commented....
Comment #9
func0der commentedComment #11
mpotter commentedMake sure you are creating your patch files correctly as per the drupal.org documentation. Looks like your patch file contains header information that is causing it to fail the testing.
Comment #12
func0der commentedI know how to create patches for Drupal modules, but my IDE removed the trailing spaces from the patch. That's why it does not work properly.
Comment #13
func0der commentedOKay, this is going to leave a bad mark on my reputation.
Comment #14
func0der commentedComment #15
alesr commentedFixed patch with a single line.
Comment #17
mpotter commentedOK, Committed this to 5bce5df.
alesr: Not sure why you posted the same patch as in #13. I committed the one from #13 because fixing the trailing whitespace is still useful.
Unfortunately I screwed up the patch attribution credit...func0der I'm really sorry I didn't give you the author credit for the patch. DrEditor's git command gave credit to alesr and I was too fast and didn't notice that clicking the different radio buttons to change the credit doesn't actually update the git message on the fly.