in file : /core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php

The following is the changes 

-   * @param \Symfony\Component\EventDispatcher\IntrospectableContainerInterface $container
+   * @param \Symfony\Component\DependencyInjection\IntrospectableContainerInterface $container
CommentFileSizeAuthor
#10 2602872-3.patch849 bytesrakesh.gectcr
#3 2602872-2.patch849 bytesrakesh.gectcr
wrong-@param-doc-ContainerAwareEventDispatcher-1.patch849 bytesrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, wrong-@param-doc-ContainerAwareEventDispatcher-1.patch, failed testing.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new 2602872-2.patch849 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

Thanks! Looks fine. And in general: Thanks for reporting (not to mention fixing!) documentation problems when you find them, rather than just letting them sit there.

The last submitted patch, wrong-@param-doc-ContainerAwareEventDispatcher-1.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2602872-2.patch, failed testing.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Reviewed & tested by the community

removed the failed patch , keeping back to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2602872-2.patch, failed testing.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new 2602872-3.patch849 bytes

Just tried recreating the patch, exactly same changes.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Reviewed & tested by the community

Test got passed, I am keeping back to RTBC.

The last submitted patch, 3: 2602872-2.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 6adc8ba on 8.0.x 
    Issue #2602872 by rakesh.gectcr: Wrong @param doc for construct function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.