Hi,

It would be nice to set the location of the whatsapp share button by making the page title configurable in the admin interface.

I would be happy to make a patch file for this feature.

Let me know if you are interested.

CommentFileSizeAuthor
#4 whatsappshare-configurable_placement-2601460-4.patch3.23 KBscuba_fly
#3 whatsappshare-configurable_placement-2601460-3.patch3.67 KBscuba_fly

Comments

scuba_fly created an issue. See original summary.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Assigned: Unassigned » scuba_fly

I have changed the module locally but don't have time to upload the files right now. I'll submit a patch tommorow

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Assigned: scuba_fly » Unassigned
Status: Active » Needs review
StatusFileSize
new whatsappshare-configurable_placement-2601460-3.patch3.67 KB
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Version: 7.x-1.0 » 7.x-1.x-dev
StatusFileSize
new whatsappshare-configurable_placement-2601460-4.patch3.23 KB

Patched against the dev version(s) now :) 7.x-1.x.dev branch === 7.x-2.x.dev branch as it is now.

The difference between the previous patch #3 is that the info file does not contain the 1.0 information added by drupal.org

pranavpathak’s picture

pranavpathak commented

Hi @scuba_fly,

Thanks for submitting patch for whatsappshare. Yes this functionality is good in order to give more option to admin.
Now a days I am busy that's why I did not get time to review and reply back to you.
Anyways in this weekend I will check and update the code.

Once again thanks.

regards,
Pranav

pranavpathak’s picture

pranavpathak commented

Hi @@scuba_fly,

Your patch is excepted and it is on production with new version 7.x-2.0.

Once again thanks.

regards,
Pranav Pathak

pranavpathak’s picture

pranavpathak commented
Version: 7.x-1.x-dev » 7.x-2.0
Assigned: Unassigned » pranavpathak
Status: Needs review » Closed (fixed)