Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
config_translation.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Oct 2015 at 11:45 UTC
Updated:
10 Nov 2015 at 13:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heykarthikwithuComment #3
tstoecklerThanks, looks good!
One note:
In general it's unnecessary to use the word "service" explicitly, because that's an implementation detail and from the point of view of ConfigTranslationOverviewAccess it's irrelevant whether the language manager is a service or not.
Don't think it's specifically wrong, though, so setting to RTBC.
Comment #4
heykarthikwithuok, thanks @tstoeckler.
Comment #5
heykarthikwithuComment #6
alexpottPlease merge with #2601244: Removal of unused variable in function config_translation_config_translation_info(&$info)
Comment #7
alexpottIgnore me I thought this was a variable remove patch... it wasn't
Comment #8
alexpottCommitted aeae48d and pushed to 8.0.x. Thanks!