ShortcutSetStorage::__construct documentation of @param \Drupal\Core\Config\StorageInterface $config_storage is to be removed.

CommentFileSizeAuthor
#2 2601162.patch772 bytesheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Active » Needs review
StatusFileSize
new 2601162.patch772 bytes
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly to 8.0.x and confirmed that the @param for $config_storage is not needed, as the method no longer accepts that parameter. Nicely spotted, thanks!

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

Thanks @nicrodgers.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +rc eligible

Thanks @heykarthikwithu for the patch and fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b336472 and pushed to 8.0.x. Thanks!

  • alexpott committed b336472 on 
    Issue #2601162 by heykarthikwithu: ShortcutSetStorage::__construct...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.