Remove the unused variable BookManager::getActiveTrailIds($bid, $link);

CommentFileSizeAuthor
#2 2600990.patch618 bytesheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
StatusFileSize
new 2600990.patch618 bytes
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Active » Needs review
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Issue tags: +rc eligible
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Needs review » Reviewed & tested by the community

Patch applied without errors against latest 8.0.x and confirmed the $nid variable is unused. Nice catch!

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

Thanks @nicrodgers

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Yep this variable is totally unused. Committed 5603f5a and pushed to 8.0.x. Thanks!

  • alexpott committed 5603f5a on 8.0.x 
    Issue #2600990 by heykarthikwithu: Removal of unused variable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.