It could be nice to have possibility to change field type that need to highlight.

Here is a patch

CommentFileSizeAuthor
#8 search_api_solr-2599658-8.patch1.95 KBloparev
#8 interdiff-2599658-6-8.txt1.44 KBloparev
#2 search_api_solr-2599658.patch2.44 KBloparev
#6 search_api_solr-2599658-6.patch1.29 KBloparev

Comments

Loparev created an issue. See original summary.

loparev’s picture

loparev commented
StatusFileSize
new search_api_solr-2599658.patch2.44 KB
loparev’s picture

loparev commented
Issue summary: View changes
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Sorry, but I fear that is much too specialized to be added to the module. I can't imagine more than a handful of people would actually use this, and it makes the UI (even) harder to understand for everyone.
I guess I could live with a hidden variable for this, though. (However, if you create a patch for that, please also fix the hard-coded length of the prefix (in the substr() call)!)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Needs work
loparev’s picture

loparev commented
Status: Needs work » Needs review
StatusFileSize
new search_api_solr-2599658-6.patch1.29 KB

Hi.

I provided a hidden variable and fixed the hard-coded length of prefix.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Needs work

Thanks.
Please also document the variable in the "Hidden variables" section of README.txt, and use substr() with strlen() for the check, not strpos() (which has worse performance for non-matches).

loparev’s picture

loparev commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2599658-6-8.txt1.44 KB
new search_api_solr-2599658-8.patch1.95 KB
loparev’s picture

loparev commented
Title: Add possibility to highlighted other field types (not only fulltext) » Add possibility to highlight other field types (not only fulltext)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Thanks, looks great!
I just changed the README description a bit and then committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.