PanelsDisplayVariant::getLayout() doesn't use dependency injection, which makes it harder to unit test. It should be taking advantage of its ContainerFactoryPluginInterface heritage.

CommentFileSizeAuthor
#2 2599356-2.patch3.96 KBphenaproxima
panels-display-variant-dependency-injection.patch2.77 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2599356-2.patch3.96 KB

Whoops -- fixed a broken test.

The last submitted patch, panels-display-variant-dependency-injection.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

Sweet, thanks! This will help write more tests for Panels. Looks great to me!

The last submitted patch, panels-display-variant-dependency-injection.patch, failed testing.

  • japerry committed 4278e08 on 8.x-3.x authored by phenaproxima 
    Issue #2599356 by phenaproxima, dsnopek: PanelsDisplayVariant should use...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Yay for more tests! fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.