Problem/Motivation

After the core issue #2073217: Remove the $langcode parameter from the entity view/render system, the $langcode parameter was removed from hook_entity_view(). This has broken sms_user.module which uses that hook

Proposed resolution

Adjust the sms_user_entity_view() function to match new signature.

Remaining tasks

Patch.
Reviews.
Commit.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 smsframework-2598640-5.patch1.83 KBalmaudoh
#2 smsframework-2598640-2.patch915 bytesalmaudoh

Comments

almaudoh created an issue. See original summary.

almaudoh’s picture

almaudoh commented
Status: Active » Needs review
StatusFileSize
new smsframework-2598640-2.patch915 bytes

Here's the patch

Status: Needs review » Needs work

The last submitted patch, 2: smsframework-2598640-2.patch, failed testing.

The last submitted patch, 2: smsframework-2598640-2.patch, failed testing.

almaudoh’s picture

almaudoh commented
Status: Needs work » Needs review
StatusFileSize
new smsframework-2598640-5.patch1.83 KB

Added a small patch to fix the TranslationWrapper related test fails.

Status: Needs review » Needs work

The last submitted patch, 5: smsframework-2598640-5.patch, failed testing.

  • almaudoh committed efe8ee1 on 8.x-1.x 
    Issue #2598640 by almaudoh: Removal of $langcode parameter in...
almaudoh’s picture

almaudoh commented
Status: Needs work » Fixed

Committed / pushed to 8.x-1.x. The fail on PHP 7 is a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.