All of the relation rules tests were just silently skipped with some if (module_exists('rules')) conditions and as it is now the tests are not even passing and we might have several Rules / Entity API issues.

CommentFileSizeAuthor
#4 fix-broken-rules-tests-2597055-4.patch10.72 KBmikran
#4 interdiff.txt686 bytesmikran
#2 remove-rules-exists-checks-2597055-1.patch10.36 KBmikran

Comments

mikran created an issue. See original summary.

mikran’s picture

mikran commented
Status: Active » Needs review
StatusFileSize
new remove-rules-exists-checks-2597055-1.patch10.36 KB
mikran’s picture

mikran commented
Issue summary: View changes
mikran’s picture

mikran commented
StatusFileSize
new interdiff.txt686 bytes
new fix-broken-rules-tests-2597055-4.patch10.72 KB

Testbot won't test these but tests are passing locally now with these changes. interdiff.txt is the relevant part.

  • mikran committed beba798 on 7.x-1.x 
    Issue #2597055 by mikran: Fix broken rules tests.
mikran’s picture

mikran commented
Status: Needs review » Fixed

and testbot agrees with the fix. Yay, finally we have working tests for rules / entity things.

The last submitted patch, 2: remove-rules-exists-checks-2597055-1.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 4: fix-broken-rules-tests-2597055-4.patch, failed testing.

mikran’s picture

mikran commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.