The menu item added in menu_example.module that was intended to show how to add items to a non-default menu ('Menu Example: Menu in alternate menu') does not work.

The example attempts to add it to primary-links, but I think that is gone in D7 (see: https://api.drupal.org/api/drupal/modules%21menu%21menu.install/function...). Changing 'primary-links' to 'main-menu' seems to fix the issue.

CommentFileSizeAuthor
#6 example-fix_alternate_menu_example-2596863-6-D7.patch1.43 KBsdstyles
#2 example-fix_alternate_menu_example-2596863-2-D7.patch601 bytesmilodesc

Comments

milodesc created an issue. See original summary.

milodesc’s picture

milodesc
he/him
commented
StatusFileSize
new example-fix_alternate_menu_example-2596863-2-D7.patch601 bytes
milodesc’s picture

milodesc
he/him
commented
Status: Active » Needs review
milodesc’s picture

milodesc
he/him
commented
Issue summary: View changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Assigned: milodesc » Unassigned
Status: Needs review » Needs work
Issue tags: +Novice, +Needs tests 
+++ b/menu_example/menu_example.module
@@ -74,7 +74,7 @@ function menu_example_menu() {
     'page arguments' => array(t('This will be in the Primary Links menu instead of the default Navigation menu')),

This text needs updating as well, so it mentions the main menu instead of Primary Links.

Also we need to test two things:

  1. That the alternate menu item appears on the front page.
  2. That examples/menu_example_alternate_menu is accessible. (That is, you get a 200 when you go to it.)

Un-assigning @milodesc, marking Novice and Needs tests so that someone else can work on this if they want to. Re-assign yourself, @milodesc, if you'd like to continue.

Thanks!

sdstyles’s picture

sdstyles commented
Status: Needs work » Needs review
StatusFileSize
new example-fix_alternate_menu_example-2596863-6-D7.patch1.43 KB
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Fixed
Issue tags: -Novice, -Needs tests

Nice, thanks!

Committed.

  • Mile23 committed bb38f50 on authored by milodesc 
    Issue #2596863 by milodesc, sdstyles: Update menu_name for the alternate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.