Problem/Motivation

As a subtask of #2469713: Step 2: Create a JavaScriptTestBase using PhantomJs Driver/Binary we want to extract from phantomjs driver.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2596801-2.patch168.08 KBalexpott
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

dawehner created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
168.08 KB

That was not so simple with the new merge plugin for composer.

Steps to do this:

  1. Apply patch to core/lib/Drupal/Core/Composer/Composer.php
  2. Do composer require --dev jcalderonzumba/gastonjs in Drupal root
  3. Move package from composer.json to core/composer.json
  4. Do composer update nothing to fix hashes
alexpott’s picture

Issue tags: +rc eligible

We're adding this library for testing purposes so I think this is rc eligible.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thanks a lot alex for helping out this this one!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks like this has sign-off from a framework manager (obviously :P). It is in core for the purpose of making testing better. From the sound of it on the ground here at the BADCamp authoring experience summit, the more tools we have available for this kind of stuff in core, the better off contrib is going to be, so works from a "contrib project (soft) blocker" POV as well.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed dcdb03e on
    Issue #2596801 by alexpott, dawehner: Step 1.75: Include the PhantomJS...
Wim Leers’s picture

WOOOOT! Front-end testing getting closer than ever!

dawehner’s picture

@Wim Leers
You haven't seen step 1.875 yet ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.