Problem/Motivation

This time we actually use the phantomjs driver, not just gastonjs

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2600176-2.patch60.36 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Status: Fixed » Active

No this is not fixed

alexpott’s picture

Status: Active » Needs review
FileSize
60.36 KB

Here's a patch to get the next library in :)

alexpott’s picture

  1. +++ b/composer.lock
    @@ -2004,7 +2004,7 @@
    -                "url": "https://api.github.com/repos/wikimedia/composer-merge-plugin/zipball/6bfcdcfe0aab6c11dcccfbd28dea01a592afd5b3",
    +                "url": "https://api.github.com/repos/wikimedia/composer-merge-plugin/zipball/6196fdb001faf681f92db2ae10abafb5815affde",
    

    I'm not sure why this changes but it does. No actually changes occur due to this.

  2. +++ b/core/lib/Drupal/Core/Composer/Composer.php
    @@ -31,9 +31,8 @@ class Composer {
    -    'jcalderonzumba/gastonjs' => ['docs'],
    -    'jcalderonzumba/gastonjs' => ['examples'],
    -    'jcalderonzumba/gastonjs' => ['tests'],
    +    'jcalderonzumba/gastonjs' => ['docs', 'examples', 'tests'],
    

    I got this wrong in the last patch. There is no harm in fixing this here.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

I don't think #4.2 is worth sweating over. The rest is straight composer.

  • jhodgdon committed 15d0695 on 8.0.x
    Issue #2600176 by alexpott, dawehner, tim.plunkett: Step 1.875: Include...
jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.0.x (with webchick standing by and alexpott's blessing).

larowlan’s picture

Bring on step 1.9375

jhodgdon’s picture

Wow. Went and read some of the parent/sibling issues. JavaScript testing in Core FTW!!!! I'm honored to have played a (very very) small part in making this possible. :)

(That was fun -- I really truly had zero idea what I was committing there last night or why, it was just Alex saying "Can you please commit this?" and I said "It's not docs!" and Alex and Angie saying "Yeah, but you have your laptop here, please?". Hee hee hee.)

elachlan’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.