As customer and Acquia Support, having a way to trace an Acquia Search Solr request back to an originating HTTP request to Drupal would help out greatly to debug many issues.

My proposal would be to basically add this ID the same way we already create the unique request_id that goes to the Solr backend.

CommentFileSizeAuthor
#9 acquia-connector-7.x-3.x-add_x_request_id-2596675-9.patch1.15 KBjanusman
#6 acquia-connector-add_x_request_id-2596675.patch1.15 KBStanislav Mixnovich
#4 to_ease_debugging_add-2596675-4.patch1.02 KBjanusman
#2 acquia_connector-add-x-request-id-2596675-D7.patch1.01 KBjanusman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

janusman created an issue. See original summary.

janusman’s picture

janusman CreditAttribution: janusman at Acquia commented
Status: Active » Needs review
FileSize
acquia_connector-add-x-request-id-2596675-D7.patch1.01 KB

Patch for review.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh at Acquia commented
Status: Needs review » Needs work 
+++ b/acquia_search/Acquia_Search_Service.php
@@ -34,6 +35,10 @@ class AcquiaSearchService extends DrupalApacheSolrService {
+    if (isset($_ENV['HTTP_X_REQUEST_ID'])) {

Can it ever be set but be empty?

janusman’s picture

janusman CreditAttribution: janusman at Acquia commented
Status: Needs work » Needs review
FileSize
to_ease_debugging_add-2596675-4.patch1.02 KB

New patch.

Logic for this patch:

* Adds x-request-id=- to the Solr request path, whenever the X-Request-ID header is not present, or present but has no value.
* Adds x-request-id={actual value of the X-Request-ID}, if present and has some value.

I am not thinking of ever omitting the added x-request-id=... to the Solr request, since that means we will not be able to tell between the X-Request-ID header not being there, or if we are dealing with older versions of the module.

janusman’s picture

janusman CreditAttribution: janusman at Acquia commented
Related issues: +#2597740: To ease debugging, add $_ENV['HTTP_X_REQUEST_ID'] (if present) to outgoing acquia_search URLs
Stanislav Mixnovich’s picture

Stanislav Mixnovich CreditAttribution: Stanislav Mixnovich commented
FileSize
acquia-connector-add_x_request_id-2596675.patch1.15 KB
Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh at Acquia commented
Status: Needs review » Reviewed & tested by the community

Good to go. If nobody objects, I can commit this tomorrow.

Stanislav Mixnovich’s picture

Stanislav Mixnovich CreditAttribution: Stanislav Mixnovich commented
Status: Reviewed & tested by the community » Closed (fixed)
janusman’s picture

janusman CreditAttribution: janusman at Acquia commented
Status: Closed (fixed) » Needs review
FileSize
acquia-connector-7.x-3.x-add_x_request_id-2596675-9.patch1.15 KB

Needs porting to 7.x-3.x.

Here's a patch.

  • janusman authored c4505dd on 7.x-3.x 
    Issue #2596675 by janusman: To ease debugging, add $_ENV['...
irek02’s picture

irek02 CreditAttribution: irek02 at Acquia commented
Status: Needs review » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.