Closed (fixed)
Project:
Commerce Product Option
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Oct 2015 at 10:13 UTC
Updated:
21 Mar 2017 at 15:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dieuweHave recreated the patch with
git diffand updated it to be run relative to module directory.Also changed the use of
else iftoelseifand placed theelseon newline.Depending on your Commerce setup, this patch is absolutely required to make this module work so I am setting this to critical. I didn't dig further into seeing what combination of modules makes this happen.
Without this patch your
commerce_optiondatabase table will stay empty because no data will ever be saved.Comment #3
dieuweClarify title (this issue doesn't actually have anything to do with "sets", just the options data.
Comment #4
dieuweTurns out this is actually already implemented in the latest dev (stumbled upon that while looking into another issue).
Comment #5
benjifisherThis was fixed in #2417947: Commerce 7.x-1.11: Option values are not stored. It is a little hard to find that issue since it is tagged as Version 7.x-2.x-dev. The patch was committed to the 7.x-1.x branch as well. I have added it as a related issue.
@dieuwe, it is usually a good practice to mark an issue "Fixed". After two weeks with no further comments, it will automatically change to "Closed (fixed)". In this case, it would be even better to mark it as a duplicate if you had been able to find #2417947.
BTW, this fix was the last thing committed to the 7.x-1.x branch: 2015-02-05.
Comment #6
benjifisherIt looks as though the 7.x-1.x-dev version of this module is essentially the same as the 7.x-1.0-beta2 version except for this issue. That is because the second-to-last commit on the 7.x-1.x branch is
Basically, the 7.x-1.x branch is abandoned, and there is no upgrade path to the 7.x-2.x branch. :-(
Comment #7
benjifisherFor convenience, I am uploading two patches. One is the version that was applied to the 7.x-1.x branch by the maintainer. That introduces a lot of whitespace changes, so I have also attached a version that suppresses the lines where only whitespace is changed. This is useful only for comparing to the other patches on this issue: the "nows" version of the patch does not apply.