I tried to use 7.x-2.x-dev with Commerce 7.x-1.11: There seems to be something wrong with the Views integration.

I've added the relationship "Commerce Line Item: Commerce options referenced by this line item" and the option fields to my cart view but the selected values don't show up. (It works fine with Commerce 7.x-1.10)

CommentFileSizeAuthor
#22 2417947-option-update-22.patch1.84 KBbenjifisher

Comments

Anonymous’s picture

Do you get any errors? Any messages in the log?

nelslynn’s picture

I'm having this issue to. The option values don't show up in the view because they are not in populated in the database (commerce_option table shows no values for the options associated with the product). This just started happening after upgrading to Commerce 7.x-1.1.

I'm here to test... seems like a pretty serious issue as it's trickling down to all order notifications, order fulfillment, etc.

Anonymous’s picture

Title: Views integration with Commerce 7.x-1.11 » Commerce 7.x-1.11: Option values are not stored
Priority: Normal » Major

@nelslynn: I've checked my database. You are right. If I add something to my cart "commerce_option" stays empty.
"Views integration with Commerce 7.x-1.11" doesn't seem to be a good title for this issue. Let's rename it.

Anonymous’s picture

I'm thinking it is this commit: https://www.drupal.org/node/2332333 that causes the issue. Will investigate.

  • 32fee54 committed on 7.x-2.x
    Issue #2417947 Get current product from different data, making it...
Anonymous’s picture

Pushed a fix. Please test the latest dev.

Anonymous’s picture

Status: Active » Needs review
nelslynn’s picture

Thanks for the quick fix. Unfortunately, I just noticed I'm using version 7.x-1.0-beta2+34-dev of Commerce Product Option. Will there be a fix for this version 7.x-1.0-beta2+34-dev? Do I need to start another issue?

Or, any suggestions on how to upgrade to version 7.x-2.x-dev, as it states it's not recommended to upgrade to the 2.x branch.

Anonymous’s picture

I've updated the 1-x branch as well, please test and let me know if it works.

Anonymous’s picture

Fix works perfectly for me. Thanks!

bendev’s picture

The fix in 1-x branch dev version works for me as well.

Thank you !!! very much appreciated

Anonymous’s picture

Status: Needs review » Fixed

You're welcome :)

wolvern’s picture

Tested #6 with commerce 1.11 and commerce_option-7.x-2.x-dev. The table commerce_option is still empty after adding items to cart. Option values are also unavailable in views via the aforementioned relationship.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nelslynn’s picture

Status: Closed (fixed) » Active

Tested commerce_option-7.x-1.x-dev with commerce 1.11 and it's still not working for me either. The table in commerce_option is still empty, and option values are unavailable in views. I think this should be open again until this works proper in all situations.

anybody’s picture

Priority: Major » Critical

I can confirm #15 which currently completely breaks the store functionality!
I'm setting up the priority to Critical though.

commerce_option-7.x-1.x-dev and commerce 1.11! Caches cleared, etc.!

anybody’s picture

Update: I was finally able to fix it by also applying the patch from commerce_pricing_attributes.module (#2420303: Problems with display update and cart pricing after Commerce 7.x-1.11 update) which I was also using. So I'll mark it as related to help others.

Both problems seem to be based on the same change in DC mentioned above.

Thanks a lot for your hard work!

Finally: I think a new stable release should be created because the current one does not work anymore with the latest DC version.

bluesman2014’s picture

I agree. I tried applying the patch you mentioned @Anybody (from #20) but my options still aren't saving.

Any news on a new release?

Anonymous’s picture

Priority: Critical » Normal

@saulelis I have tested the latest dev of commerce_option (2.x branch) with Commerce 1.11 on a few local installs, it works fine for me. Can you maybe elaborate on your setup?

As for the 7-1.x version, I can hardly keep up with the 2.x version so it is doubtful there will be a new release soon for the branch, or a fix for the problem. Everyone is of course welcome to contribute patches.

bluesman2014’s picture

Will there be a (non-dev) 2.x release soon?

Anonymous’s picture

Status: Active » Closed (fixed)

Closing this issue. I can't see any problems with the 2.x branch and the latest commerce release.

@bluesman2014 I don't know really ... Although quite stable, I feel the current dev still needs some more testing.

benjifisher’s picture

StatusFileSize
new1.84 KB

For reference, I am attaching a patch based on what @samspinoy already committed.