Menu link URL should be translatable

The problem is, its not that easy, when the URL is translatable, you also need multiple entries in the menu_tree table, you need to take care of multilingual etc. and boom it will get hard.

No, its not. For static menu links we store the TranslatableString object.
For manually created menu links we have some logic on render time for that: \Drupal\menu_link_content\Plugin\Menu\MenuLinkContent::getTitle

The problem though is that in case your menu link URLs are translatable queries against the {menu_tree} table against the URL/route needs to behave differently. This is the main difference, you don't filter by the title.

Do you mind explain how general usecase, I think we should more try to solve that, I hope better hope in that.

General usecase is when you try to link something to external service, you need to be able to set different URL for different languages because of the internal link generator is unable to create them.

Okay well for external URLs it is easier indeed, maybe for those we could actually allow it when we have all the various validation in place.

This is certainly a feature request for 8.1.x now.

Hi everyone,

I have the need for this in one project, so I used the patch in #3, but also tried to add some validations to ensure that only external URLs can be translated. Then, when we add a translation and edit the original, I don't know what should happen if we try to change the link to internal, or if we try to add an internal link to the translation.

For this project it was enough to make the internal links always internal, and the externals also always externals, but I'm sure that's not the desired solution. Also, I'm not sure that I'm doing this in the right place. Anyway, I upload the patch in case someone can find it useful.

For me it was big surprise, that I cannot translate menu item urls. Now I need to build huge menus (including mainly external links) twice to get the wanted behaviour.

So +1 if someone creates solutions to this :)

Rerolled #13 to 8.4.x

I got the error with old links. I can't change internal URL to external URL its validation issue. So I removed this part from the patch.
Please review it.

I used patch 19 from #22 on drupal version 8.9.14

The patch almost works. After I save my menu item with an external link the text (all translations) will be removed from the url field and it will save the content separate from the original language. However I had the following issues with the current version of this patch.

1. This only worked on the translations but the original language kept being for all translations so changing and saving the original item would always overwrite all other languages.
2. You can technically now fill in an external url and then save the page. Then you can fill in an internal link and it will save the translation with this link.

So there should either be some ajax call which i think makes more sense because then you can swap between internal and external and/or on submit there should be a check to make sure the link being saved is still internal or external. And the original translation should be translatable. On top of that it needs to be updated for the newer drupal versions and tests need fixing.

Hi,

There was a multisite build for core 9.4. One of these installations was not multilingual. Patch #22 was giving the following error. I updated the patch as attached.

InvalidArgumentException: The URI '' is invalid. You must use a valid URI scheme.Array ( ) in Drupal\Core\Url::fromUri() (line 296 of /var/www/html/web/core/lib/Drupal/Core/Url.php).

I've created a MR rerolling the patch from #33 to the latest Drupal 11.x release. I'm attaching also a static patch to apply safely from composer

Believe this feature will need test coverage.

Have not reviewed

Issue:
When link field is made untranslatable for a particular menu type from /admin/config/regional/content-language, I get the following error:

Error: Call to undefined method Drupal\Core\Field\Entity\BaseFieldOverride::setItemDefinition() in Drupal\menu_link_content\Entity\MenuLinkContent->setTranslationConstraints() (line 444 of /var/www/html/docroot/core/modules/menu_link_content/src/Entity/MenuLinkContent.php).

While debugging, i found that when link field is translatable, the $item_definition object is an instance of the class Drupal\Core\Field\BaseFieldDefinition and when it is non-translatable, the object is an instance of the class Drupal\Core\Field\Entity\BaseFieldOverride where the setItemDefinition method is not defined.

We should add an early return if the link field is non-translable in the field configuration.

Fix for issue described in #40

I made a reroll patch for the drupal core version 11.2.0