Hi, I want to add hook_help implementation in views. I have copied text from D6 hook_help.

Problem/Motivation

Improves the module help by providing a Help text page per the HELP standards for Core and Contrib. :-)

Proposed resolution

Write a help text according to https://www.drupal.org/node/632280

Remaining tasks

revisions to patch based on back port from D8 description

User interface changes

Improves the UI

CommentFileSizeAuthor
#12 interdiff-4-11.txt7.76 KBdbt102
#11 2595333-Add_hook_help_implementation-11.patch4.61 KBdbt102
#8 interdiff-4-7.txt5.9 KBdbt102
#8 2595333-Add_hook_help_implementation-7.patch2.7 KBdbt102
#6 Help | develop 2016-06-07 13-07-11.png69.46 KBdhruveshdtripathi
#4 hook_help-2595333-4.patch3.6 KBcherebedov.s
#2 hook_help-2595333-1.patch3.6 KBcherebedov.s

Comments

cherebedov.s created an issue. See original summary.

cherebedov.s’s picture

cherebedov.s commented
StatusFileSize
new hook_help-2595333-1.patch3.6 KB

It is patch. Thank's.

cherebedov.s’s picture

cherebedov.s commented
Status: Active » Needs review
cherebedov.s’s picture

cherebedov.s commented
StatusFileSize
new hook_help-2595333-4.patch3.6 KB

It is a patch with the valid comment-number. Thank's.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: cherebedov.s » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Help | develop 2016-06-07 13-07-11.png69.46 KB

Patch applied successfully.

dbt102’s picture

dbt102 commented
Component: Documentation » Code
Assigned: dhruveshdtripathi » dbt102
Category: Feature request » Task
Issue summary: View changes
Status: Reviewed & tested by the community » Active
dbt102’s picture

dbt102 commented
StatusFileSize
new 2595333-Add_hook_help_implementation-7.patch2.7 KB
new interdiff-4-7.txt5.9 KB

This patch is an update to the patch provided in comment #4. It 'back-ports' the HELP text from the D8 version of views (from core). It includes the 'Uses' section that is recommended pr the HELP standard referenced in the updated description of this issue.

Note: I've also created the HELP text for ViewsUI and will submit that in a bit.

dbt102’s picture

dbt102 commented
Assigned: dbt102 » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 2595333-Add_hook_help_implementation-7.patch, failed testing.

dbt102’s picture

dbt102 commented
StatusFileSize
new 2595333-Add_hook_help_implementation-11.patch4.61 KB

this expands on the patch of #8 by including HELP for the Views_UI module as well (based on the text for D8_Views).

dbt102’s picture

dbt102 commented
StatusFileSize
new interdiff-4-11.txt7.76 KB

interdiff to view changes from #4 --> #11

dbt102’s picture

dbt102 commented
Status: Needs work » Needs review
dbt102’s picture

dbt102 commented

just checking back for reviews/comments

dhruveshdtripathi’s picture

dhruveshdtripathi commented
renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Status: Needs review » Reviewed & tested by the community
Issue tags: +ciandt-contrib

Hi people.

Thank you very much for contributions.

I fixed just simple items:

   7 | ERROR   | Whitespace found at end of line
  22 | ERROR   | Line indented incorrectly; expected 6 spaces, found 8
  36 | ERROR   | Expected 1 blank line after function; 2 found

Regards.

  • RenatoG committed 940206e on 7.x-3.x authored by dbt102 
    Issue #2595333 by dbt102, cherebedov.s, dhruveshdtripathi, RenatoG: Add...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2866162: Plan for Views 7.x-3.18 release