Remodel packages as objects

@dawehner: great start!

1. +++ b/modules/features_ui/src/Form/FeaturesEditForm.php
   @@ -47,7 +48,7 @@ class FeaturesEditForm extends FormBase {
       * Current package array being edited.
   

   Could change to "Current package being edited."

   There are various other code comments were we could change "package array" to "package".

2. +++ b/modules/features_ui/src/Form/FeaturesEditForm.php
   @@ -795,17 +794,18 @@ class FeaturesEditForm extends FormBase {
   -    $this->package['name'] = $form_state->getValue('name');
   -    $this->package['machine_name'] = $bundle->getFullName($form_state->getValue('machine_name'));
   -    $this->package['description'] = $form_state->getValue('description');
   -    $this->package['version'] = $form_state->getValue('version');
   -    $this->package['bundle'] = $bundle->getMachineName();
   +    $this->package = new Package($form_state->getValue('machine_name'), [
   +      'name' => $form_state->getValue('name'),
   +      'description' => $form_state->getValue('description'),
   +      'version' => $form_state->getValue('version'),
   +      'bundle' => $bundle->getMachineName(),
   +    ]);
   

   The revised code drops the call to $bundle->getFullName(). Is that to fix a bug?

3. +++ b/src/Plugin/FeaturesAssignment/FeaturesAssignmentProfile.php
   @@ -148,6 +148,7 @@ class FeaturesAssignmentProfile extends FeaturesAssignmentMethodBase {
   +            // @fixme
   ...
              }
   

   The problem here is that the code we need to replace merges into the package array, which repeats these keys from the info array ('dependencies', 'themes').

   Maybe:

   $info  [
     'dependencies' => $profile_package->getDependencies(),
     'themes' => $profile_package->getThemes(),
   ];
   $info = $this->featuresManager->mergeInfoArray($info, $profile_info);
   $profile_package->setDependencies($info['dependencies']);
   $profile_package->setThemes($info['themes']);
   

4. +++ b/src/Plugin/FeaturesGeneration/FeaturesGenerationArchive.php
   @@ -70,11 +73,13 @@ class FeaturesGenerationArchive extends FeaturesGenerationMethodBase {
   -          $package['files'][] = [
   +          $files = $package->getFiles();
   +          $files[] = [
                'filename' => $file->filename,
                'subdirectory' => $subdirectory,
                'string' => file_get_contents($file->uri)
              ];
   +          $package->setFiles($files);
   

   Could maybe use $package->appendFile() here since we don't need to specify the file index (as we do with e.g. 'info', to enable later merging into that file)?

This is looking great.

I did a string search for $package[ and there are a few places that probably still need fixing up, in modules/features_ui/src/Form/FeaturesDiffForm.php, src/FeaturesGenerator.php, src/FeaturesManager.php, and tests/src/Kernel/FeaturesGenerateTest.php.

1. +++ b/modules/features_ui/src/Form/FeaturesEditForm.php
   @@ -603,7 +602,6 @@ class FeaturesEditForm extends FormBase {
   -    $export = $this->package;
   

   From the subsequent code in this method, which works with $export['package'], it looks like instead of removing this line we should do something like:

   $export = [
     'package' => $this->package,
   ];
   

2. +++ b/modules/features_ui/src/Form/FeaturesExportForm.php
   @@ -282,36 +283,36 @@ class FeaturesExportForm extends FormBase {
   +   * @param \Drupal\features\Package $package
       *   The package name.
   

   Comment should be "The package." rather than "The package name."

3. +++ b/src/FeaturesManager.php
   @@ -317,7 +317,7 @@ class FeaturesManager implements FeaturesManagerInterface {
   -    return \Drupal::service('info_parser')->parse($extension->getPathname());
   +    return \Drupal::service('info_parser')->parse(\Drupal::root() . '/' . $extension->getPathname());
   

   This looks like an unrelated bugfix? Worth catching and no prob to add here.

All the fixes look good.

I'm getting some failures for Drupal\features\Tests\FeaturesCreateUITest, haven't looked into them.

1. +++ b/src/FeaturesManager.php
   @@ -676,13 +680,13 @@ class FeaturesManager implements FeaturesManagerInterface {
   +      $package->setStatus($this->moduleHandler->moduleExists($extension->getName()))
            ? FeaturesManagerInterface::STATUS_ENABLED
            : FeaturesManagerInterface::STATUS_DISABLED;
   

   Should be:

         $package->setStatus($this->moduleHandler->moduleExists($extension->getName())
           ? FeaturesManagerInterface::STATUS_ENABLED
           : FeaturesManagerInterface::STATUS_DISABLED
         );
   

2. +++ b/src/Plugin/FeaturesGeneration/FeaturesGenerationArchive.php
   @@ -12,6 +12,7 @@ use Drupal\features\FeaturesGenerationMethodBase;
   +use Drupal\features\Package;
   

   Needs rerolling after a recent change.

I'm getting some failures for Drupal\features\Tests\FeaturesCreateUITest

First error includes:

Fatal error: Call to a member function getFeaturesInfo() on a non-object in /path/to/site/modules/features/src/Plugin/FeaturesAssignment/FeaturesAssignmentPackages.php on line 37

@dawehner

Given the scope of the change it will be surprising if we got absolutely everything, but my basic manual testing plus the new tests introduced here didn't show any issues.

Thanks for your amazing work and perseverance here. It's great to have this refactoring complete.