EntityDeriverBase uses StringTranslationTrait which says this in it's docblock:

* If the class is capable of injecting services from the container, it should
* inject the 'string_translation' service and assign it to
* $this->stringTranslation.

So, we should do that! My patch on #2561935: Create a block for every field (which'll take the entity as context) injected it, so if the new deriver on that patch is going to use EntityDeriverBase, I'd like it to continue to be injected. :-)

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new1.55 KB
eclipsegc’s picture

Status: Needs review » Reviewed & tested by the community

Seems sane to me.

Eclipse

  • EclipseGc committed 9d151f7 on 8.x-3.x authored by dsnopek
    Issue #2594179 by dsnopek: EntityDeriverBase should inject the string...
eclipsegc’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.