Creates "See Video" link when video field is empty

I have the same problem...
If I set cck embedded video to multiple values and no video is atached, I see 3 ""See Video"".
(sorry for my english)

Bump!

Yup. Same problem here. Just started when I upgraded to 5.x-1.2.

Total hack but you get rid of the 'See Video' if you do something like this:

  else {
     // if all else fails, then just print a 'see video' link.
    if ($no_link) {
      $output = ''; //thickbox won't work without a thumbnail
    }
    else {
     $output = ''; //thickbox won't work without a thumbnail
    }

Thank you for the hack. Hopefully this will be solved in next version :)

Whew. That felt good. Gotta love finding an answer in the forums so easily. Thank you!!

Here's some smart code to check for the "see video" links to empty embedded media fields. Stole the "if ($item['value'] && $item['provider'])" code from just above where this edit goes...

     // if all else fails, then just print a 'see video' link.
    if ($no_link) {
      $output = ''; //thickbox won't work without a thumbnail
    }
    else if ($item['value'] && $item['provider']) {
      $output = l(t('See Video'), 'node/' . $node->nid);
    }
    else {
      $output = '';
    }
 

video cck has long been deprecated. moving back to emfield

To accelerate the process, attached is a patch for pereljon's suggested fix created against version 1.2.

I have not investigated deeper yet, but I believe there is a larger issue here with video_cck (or emfield?). There is no reason why fields with empty values should be stored in the database at all. For instance, when video_cck field is set to allow multiple values on a node, once the node is saved, 4 empty fields are committed to the database. If we were to contrast this behavior against imagefield's, we'd probably notice that imagefield removes empty fields from the database all together. Wouldn't this be the desired behavior for video_cck (emfield?) as well?

the problem also finds in v1.3

agree with #13
but as we still do have have a patch that complete the idea,
maybe we can test the patch and commit it as a work around currently.

i think this issue should be solved before next 5.x version release..

Added the patch and made the two statements above them look like this = works!

    if ($no_link && $item['value'] && $item['provider']) { //thickbox requires the thumbnail returned without the link
      $output = '<img src="'. $thumbnail_url .'" width="'. $width  .'" height="'. $height  .'" alt="'. $image_alt .'" title="'. $image_title .'" />';
    }
    else if ($item['value'] && $item['provider']) {
      $output = l('<img src="'. $thumbnail_url .'" width="'. $width  .'" height="'. $height  .'" alt="'. $image_alt .'" title="'. $image_title .'" />', $link_url, array(), NULL, NULL, false, true);
    }

just add "$item['value'] && $item['provider']" to the if-statement and make the else to else if and add the same thing there.

-

The patch in #13 no longer applies against 5.x-1.3. I've re-rolled it to work with the current release. New patch is attached.

This patch appears to work fine, without the additions in #15 above.

Can the maintainers commit this to the 5.x branch? Or could we at least get a review?

This approach sees fine to me, though it no longer applies to Drupal 6. I'm going to try and go through and commit the 5.x patches we have soon.

Changing Status.

committed. thanks!