In need of the new regions, will also fix incorrect comments.

Patch coming up.

CommentFileSizeAuthor
#15 2591265-14-screenshot.jpg559.91 KBnitesh624
#15 2591265-14.png26.78 KBnitesh624
#14 2591265-14.patch2.65 KBtdnshah
#14 interdiff_9-14.txt795 bytestdnshah
#11 aws_sqs.png40.09 KBnitesh624
#10 2591265-9.patch2.58 KBtdnshah
#10 interdiff_8-9.txt3.33 KBtdnshah
#8 2591265-8.patch1.61 KBtdnshah
#2 2591265-aws_sqs-1.patch4.06 KBericduran

Comments

ericduran created an issue. See original summary.

ericduran’s picture

ericduran commented
Status: Active » Needs review
StatusFileSize
new 2591265-aws_sqs-1.patch4.06 KB

Will be testing the patch in 2 seconds.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Needs review » Needs work

The regions in that file are now gone. The docs changes are definitely a good thing to do though.

skwashd’s picture

skwashd commented

The regions list in the 7.x-1.x and 7.x-3.x branches are up to date and documented. The region list in the D8 settings form still needs updating.

bunty badgujar’s picture

bunty badgujar commented

We need to update patch with latest dev branch.

bunty badgujar’s picture

bunty badgujar commented

As discussed here https://www.drupal.org/project/aws_sqs/issues/2924431#comment-13597301

Lets update the Region list in config form according to list provided by AWS regions list

tdnshah’s picture

tdnshah commented
Assigned: ericduran » tdnshah

Will update the list and add the patch hence assigning to myself

tdnshah’s picture

tdnshah commented
Assigned: tdnshah » Unassigned
StatusFileSize
new 2591265-8.patch1.61 KB

Updated with new regions supporting AWS SQS Service.

tdnshah’s picture

tdnshah commented
Status: Needs work » Needs review
tdnshah’s picture

tdnshah commented
StatusFileSize
new interdiff_8-9.txt3.33 KB
new 2591265-9.patch2.58 KB

The Region list drop has name of the regions instead of code and also added the link to aws general region list to the firld description.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new aws_sqs.png40.09 KB

Hi @tdnshah thanks for patch on the dev branch of module see the screenshot below and also getting the updated list of regions
aws

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs review » Reviewed & tested by the community
bunty badgujar’s picture

bunty badgujar commented
Status: Reviewed & tested by the community » Needs work

@tejas, It is better to add inline tag in t() function. But, as suggested here adding href URL in t() instead of placeholder is bad example.

tdnshah’s picture

tdnshah commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_9-14.txt795 bytes
new 2591265-14.patch2.65 KB

implemented suggestions mentioned in #13

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 2591265-14.png26.78 KB
new 2591265-14-screenshot.jpg559.91 KB

patch #14 tested successfully for mescreenshot 1 screenshot 2

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs review » Reviewed & tested by the community

bunty badgujar’s picture

bunty badgujar commented
Status: Reviewed & tested by the community » Fixed

Thanks Everyone :)

tdnshah’s picture

tdnshah commented
Status: Fixed » Closed (fixed)

Closing this issue
Thank you all