Closed (fixed)
Project:
Amazon Simple Queue System
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Support request
Assigned:
Reporter:
Created:
17 Nov 2017 at 17:57 UTC
Updated:
12 May 2020 at 10:45 UTC
Jump to comment: Most recent
Comments
Comment #2
malcolm_p commentedI would also like to see a D8 release of this module. If this project is no longer being supported it'd be great to get some new maintainers. I'm willing to help as I plan to use AWS SQS extensively in D8.
Comment #3
nick_vhHappy to give you maintainership! Would you be ok if I assign the project to you?
Comment #4
malcolm_p commentedThanks, that'd be great!
Comment #5
nick_vhMalcolm, you have maintainership now!
Comment #6
a.milkovskyThanks for adding a new maintainer.
The initial issue is about re-factoring, so we can not close it.
Comment #7
malcolm_p commentedThanks Nick! Alex, hopefully I'm going to be working on this starting next week.
Comment #8
asauterChicago commentedHello, I'm not sure what the process on this is, but I would also like maintainership. I would like to test and merge this pull request. And I would like to add some new features that are available in the latest SDK and fix a bunch of code to be in line with the latest Drupal standards.
Comment #9
bunty badgujar commentedHello @Nick_vh, Any progress in this module? I am working on the same feature as this module. I would like to contribute my time. Can you give me maintainership. So that i can update module code for drupal 8 and 9.
Comment #10
bunty badgujar commentedComment #11
nick_vhMaintainership transferred, let's hope to see some life in this module again :-)
Comment #12
bunty badgujar commentedComment #13
bunty badgujar commentedComment #14
a.milkovskyAs written in #6
Thanks for adding a new maintainer.
The initial issue is about re-factoring, so we can not close it!
Please re-open the issue. The PR still needs review.
Comment #15
bunty badgujar commentedHello @Alex Milkovskyi,
In issue description it is written that the module is unstable for drupal 8. But as you can see, module now have stable release and working fine on default queue and with service. So, can you please provide patch of the re-factored code?
Also feel free to reopen this issue.
Comment #16
a.milkovskyI can not reopen this issue, because it is closed. I do not have permissions.
Yes I know, I created this issue :D
As you can see there is a pull request in the description. It is on github, because module development was on github before.
I was expecting some feedback on the proposed code changes.
But too late now, you made too many changes already.
Comment #17
bunty badgujar commented@Alex Milkovskyi, As most of the changes you proposed is already added in current release. But, i can see following interesting code in your PR which can include in this module :-
protected $initializedQueues;Let me know if you want to track these changes in separate issue or this issue? Also credit for this issue has been given to all contributors. :)
Comment #18
a.milkovskyYes, they have added quite a few. "'eu-central-1' => 'EU (Frankfurt)'" is an important one for the GDPR topic in Europe.
It is up to you. If you would like to create a new issue, just reference it here in a comment.
FYI I will not contribute a new patch any soon, because currently I do not have any related project.
Thanks for the review!
Comment #19
bunty badgujar commentedAs discussed in #17