In LocalTaskInterface documentation, we have double *are*. Fix it.

CommentFileSizeAuthor
#4 drupal-fix_double_are-documentation-2589733-4-D8.patch1.81 KBsagar ramgade
#2 2589733-2.patch629 bytesjoshi.rohit100

Comments

joshi.rohit100 created an issue. See original summary.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2589733-2.patch629 bytes

Here we go.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Good catch

sagar ramgade’s picture

sagar ramgade commented
Title: LocalTaskInterface - double 'are' » LocalTaskInterface, XssTest, RendererTest - double 'are'
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new drupal-fix_double_are-documentation-2589733-4-D8.patch1.81 KB

Did a full project search found two more in XssTest and RendereTest, patch attached to fix those.

cilefen’s picture

cilefen commented
Issue tags: +Novice, +Quick fix
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This is is a good good fix. Thanks thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

Committed 210468f and pushed to 8.0.x. Thanks!

diff --git a/core/lib/Drupal/Core/Menu/LocalTaskInterface.php b/core/lib/Drupal/Core/Menu/LocalTaskInterface.php
index ec51f46..23dd4eb 100644
--- a/core/lib/Drupal/Core/Menu/LocalTaskInterface.php
+++ b/core/lib/Drupal/Core/Menu/LocalTaskInterface.php
@@ -12,9 +12,9 @@
 /**
  * Defines an interface for menu local tasks.
  *
- * Menu local tasks are typically rendered as navigation tabs above the
- * content region, though other presentations are possible. It is convention
- * that the titles of these tasks should be short verbs if possible.
+ * Menu local tasks are typically rendered as navigation tabs above the content
+ * region, though other presentations are possible. It is convention that the
+ * titles of these tasks should be short verbs if possible.
  *
  * @see \Drupal\Core\Menu\LocalTaskManagerInterface
  */

Re-flowed comment on commit.

  • alexpott committed 210468f on 8.0.x 
    Issue #2589733 by joshi.rohit100, Sagar Ramgade: LocalTaskInterface,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.