This was found in #2584603: PHP exception on manage fields after enabling Configuration Translation

Problem/Motivation

In WebTestBase::setUp() $this->installParameters() is called and the parameters are then passed into $this->doInstall(). That method does document a $parameters variable but it never actually uses it but instead calls $this->installParameters() itself.

Proposed resolution

Remove the unneeded argument and superfluous method call.

This is 100% backwards compatible and only changes test code so is eligible during the RC.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

Status: Active » Needs review
FileSize
1.19 KB
stevector’s picture

+1 for removing unused code.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +rc eligible

Its not only that, also tests are not an API so we can change it at any given point.

Nice find @tstoeckler!

tim.plunkett’s picture

I personally would have removed the second method call and used the parameters, but either way is better than HEAD.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2b92ca2 and pushed to 8.0.x. Thanks!

  • alexpott committed 805e1d6 on
    Issue #2589599 by tstoeckler: Dead code in WebTestBase
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.