Followup from #2512210: SimpleTest - WebTestBase method creates binary-text files when the intention was to create text files, and text file creation is broken

CommentFileSizeAuthor
#2 2588529-2.patch1.43 KBDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Status: Active » Needs review
FileSize
2588529-2.patch1.43 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +Novice

I am tagging this "Novice" because a novice can provide a review on this coding-standards issue.

kikoalonsob’s picture

kikoalonsob CreditAttribution: kikoalonsob for Axel Springer España commented
Status: Needs review » Reviewed & tested by the community

It seems ok, "for" loop have the correct indentation now.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible 
+++ b/core/modules/simpletest/simpletest.module
@@ -532,24 +532,24 @@ function simpletest_classloader_register() {
-            break;
-        }
...
       }
-      $text .= "\n";
     }
+    $text .= "\n";
+  }

The diff generation here goofed me up and at first I thought this was changing the actual logic, but it's not. It's just the diff. I reviewed with git diff -W to confirm this.

As a non-disruptive, low-risk coding standards fix, this change is considered "rc eligible" and can be committed any time during RC. Reference: https://www.drupal.org/core/d8-allowed-changes#rc Committed and pushed to 8.0.x. Thanks!

  • xjm committed 120111a on 8.0.x 
    Issue #2588529 by David_Rothstein, cilefen, kikoalonsob: Code...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.