panels_page_edit_export() sets an empty title, if the panels page doesn't provide one. It should instead use panels_page_get_title, so in this case "No title" is set. This is what other administrative pages do as well.
Also, when importing a panel page that doesn't provide a title, the page title reads Import panel page ""

The enclosed patch fixes this.

CommentFileSizeAuthor
#3 panels_page_get_title_3.patch1.55 KBpancho
panels_page_get_title.patch1.51 KBpancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

Still applies with some offset.
Bumping this to get reviewed.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

Still applies with some offset.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new panels_page_get_title_3.patch1.55 KB

Rerolled after #264122: Import fails: non-stdClass object in $_SESSION['pp_import'] has been committed.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs review » Needs work

Not yet complete. On some admin pages there is still absolutely no title set.

kimadactyl’s picture

kimadactyl commented

Personally I'd rather if I didnt set a title, there was no title not "no title" :)

esmerel’s picture

esmerel commented
Status: Needs work » Closed (won't fix)

No fixes will be added to the 2.x line.