Hi,

The source language for the metatag translatable strings always is always the currently default language on the site and this overrides the setting in /admin/config/regional/i18n/strings.

This is confusing for the translation strategy as you would normally always want to have the same initial language for your translations.

CommentFileSizeAuthor
#12 metatag-n2587725-12.patch15.46 KBdamienmckenna
#10 metatag-n2587725-10.patch1.44 KBdamienmckenna
Selection_003.jpg136.45 KBdrupov
Selection_004.jpg136.76 KBdrupov
#5 metatag-n2587725-5.patch1.44 KBdamienmckenna
Selection_005.jpg97.01 KBdrupov

Comments

drupov created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Closed (duplicate)

Lets handle this in #2564483: Cannot translate metatags after last update anymore.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (duplicate) » Active
Related issues: +#2564483: Cannot translate metatags after last update anymore

Lets not handle that in #2564483: Cannot translate metatags after last update anymore. ;-)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2539438: Plan for Metatag 7.x-1.8 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2587725-5.patch1.44 KB

This should fix the problem.

drupov’s picture

drupov commented
Status: Needs review » Needs work

Sorry, the patch from #5 did not change it. If you change the site language the source string language for the translatable string switches too.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Once I fix the main i18n issue I'll work on this one and include some tests.

drupov’s picture

drupov commented

@DamienMcKenna you're the best!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2587725-10.patch1.44 KB

Rerolled.

This needs some tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Needs tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2587725-12.patch15.46 KB

Ok, lets finish this.

I've stepped through this and it appears to be working correctly with the patch, so I wrote some tests to confirm this fact.

sylus’s picture

sylus commented
Status: Needs review » Reviewed & tested by the community

Works based on manual testing as well.

Time for a 1.8 release? I think :) Again thx for all the amazing work!

  • DamienMcKenna committed ba6a04a on 7.x-1.x 
    Issue #2587725 by DamienMcKenna: Fixed display of meta tag labels in...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

@sylus: Thanks for the review. Committed.

I'm going to leave it another day, wait for any additional feedback, then probably release 1.8 tomorrow. Or I could wait for the 18th ;-)

sylus’s picture

sylus commented

Woot excited for tomorrow, thx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.