ViewUIConverter::__construct's docblock shows a second parameter \Drupal\user\SharedTempStoreFactory $temp_store_factory while first one is missing.

Proposed resolution

Adding it.

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because function docblocks should match the actual parameters.
Issue priority Normal because this is just documentation.
Unfrozen changes Unfrozen because it only fixes documentation
CommentFileSizeAuthor
#2 2585749-1.patch718 bytesheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Active » Needs review
StatusFileSize
new 2585749-1.patch718 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks perfect

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

Documentation fixes are rc eligible. Committed e678a03 and pushed to 8.0.x. Thanks!

Changed the docs to match the parent class on commit.

diff --git a/core/modules/views_ui/src/ParamConverter/ViewUIConverter.php b/core/modules/views_ui/src/ParamConverter/ViewUIConverter.php
index 31a27bf..a8c5151 100755
--- a/core/modules/views_ui/src/ParamConverter/ViewUIConverter.php
+++ b/core/modules/views_ui/src/ParamConverter/ViewUIConverter.php
@@ -43,7 +43,7 @@ class ViewUIConverter extends EntityConverter implements ParamConverterInterface
    * Constructs a new ViewUIConverter.
    *
    * @param \Drupal\Core\Entity\EntityManagerInterface $entity_manager
-   *   The entity manager interface object.
+   *   The entity manager.
    * @param \Drupal\user\SharedTempStoreFactory $temp_store_factory
    *   The factory for the temp store object.
    */

  • alexpott committed e678a03 on 8.0.x 
    Issue #2585749 by heykarthikwithu: ViewUIConverter::__construct docblock...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.