Hi there,

I have recently upgraded from 7.x-1.3 to 7.x-1.4 and noticed that the default state of my content types are not being honored. Regardless of how I set it up, it always defaults to draft.

CommentFileSizeAuthor
#2 workbench_moderation-fix_default_state-2584483-2-7.patch606 bytesjorgegc

Comments

jorgegc created an issue. See original summary.

jorgegc’s picture

jorgegc commented
Status: Active » Needs review
StatusFileSize
new workbench_moderation-fix_default_state-2584483-2-7.patch606 bytes

Submitting a patch for review.

Status: Needs review » Needs work

The last submitted patch, 2: workbench_moderation-fix_default_state-2584483-2-7.patch, failed testing.

jorgegc’s picture

jorgegc commented
Version: 7.x-1.4 » 7.x-1.x-dev
jorgegc’s picture

jorgegc commented
Status: Needs work » Needs review

Triggering tests again.

jorgegc queued 2: workbench_moderation-fix_default_state-2584483-2-7.patch for re-testing.

jorgegc’s picture

jorgegc commented
Version: 7.x-1.x-dev » 7.x-3.x-dev
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Should that maybe be called inside the function to ensure it's used anywhere that is called?

jorgegc’s picture

jorgegc commented

Hey @joelpittet, did you mean inside workbench_moderation_state_none()?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Yes, sorry for being vague

jorgegc’s picture

jorgegc commented

No worries! Although possible, I don't think the function was created for that particular purpose. Also, we would have to change the API and introduce $content_type as a dependency. I am just trying to fix the issue the simplest way possible at this stage, sorry @joelpittet!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

I was thinking that if someone was to call workbench_moderation_state_none() it should probably return the default state in all cases, but maybe I'm wrong. That way we won't run into this issue again with a different call to the same function.