Problem/Motivation

Notice: Trying to get property of non-object in twitter_status_save() (line 159 of twitter.inc).

Seems to be a RT problem.

Proposed resolution

Check to see if propry exists before using it.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Status: Active » Needs review
StatusFileSize
new954 bytes

Maybe this is the right solution?

trentl’s picture

#2 tested and worked for me. It solved the log issue of RT errors and RT's are now displaying in the Twitter feed on the website.

alexverb’s picture

Status: Needs review » Reviewed & tested by the community

#2 also works for me. Seems like a logical solution to the problem. This change won't have any adverse effects anywhere else so I'm changing status to reviewed.

apugacescu’s picture

Issue summary: View changes
StatusFileSize
new591 bytes

Importing retweets fails with the same error as described above, getting "RT @:" status values for all retweets, noticed that the properties that are used for concatenating the text are accessed as object attributes when in fact they are arrays (See screenshot http://funkyimg.com/i/2b2Kk.png). There is some inconsistency because right after that a new TwitterStatus object is created where properties are assigned right as object attributes.

apugacescu’s picture

Issue summary: View changes

Unintentionally removed issue summary when adding the patch.

  • DamienMcKenna committed da30fcf on 7.x-5.x
    Issue #2624178/#2584363 by fran seva, joelpittet, SurfinSpirit: Fixed...

  • DamienMcKenna committed 95c830c on 7.x-6.x
    Issue #2624178/#2584363 by fran seva, joelpittet, SurfinSpirit: Fixed...
damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

Thanks. I actually committed #2624178: Retweeted text not appears first which fixes the same bug, but I've updated the changelog to mention your work here too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.