Problem/Motivation
Notice: Trying to get property of non-object in twitter_status_save() (line 159 of twitter.inc).
Seems to be a RT problem.
Proposed resolution
Check to see if propry exists before using it.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | trying_to_get_property-2584363-5.patch | 591 bytes | apugacescu |
| #2 | trying_to_get_property-2584363-2.patch | 954 bytes | joelpittet |
Comments
Comment #2
joelpittetMaybe this is the right solution?
Comment #3
trentl commented#2 tested and worked for me. It solved the log issue of RT errors and RT's are now displaying in the Twitter feed on the website.
Comment #4
alexverb commented#2 also works for me. Seems like a logical solution to the problem. This change won't have any adverse effects anywhere else so I'm changing status to reviewed.
Comment #5
apugacescu commentedImporting retweets fails with the same error as described above, getting "RT @:" status values for all retweets, noticed that the properties that are used for concatenating the text are accessed as object attributes when in fact they are arrays (See screenshot http://funkyimg.com/i/2b2Kk.png). There is some inconsistency because right after that a new TwitterStatus object is created where properties are assigned right as object attributes.
Comment #6
apugacescu commentedUnintentionally removed issue summary when adding the patch.
Comment #9
damienmckennaThanks. I actually committed #2624178: Retweeted text not appears first which fixes the same bug, but I've updated the changelog to mention your work here too.