Problem/Motivation

The drop button at admin/tmgmt/jobs states
manage
abort
Delete

Drupal Core usually is uppercase first.

Proposed resolution

Make them uppercase first.

User interface changes

Consistent upper case first drop down items.

CommentFileSizeAuthor
#10 tmgmt-operations_case_fix-2583329-10.patch3.12 KBjuanse254
#8 tmgmt-operations_case_fix-2583329-8.patch2.94 KBjuanse254
#2 tmgmt-operations_case_fix-2583329-2-D8.patch4.08 KBsagar ramgade

Comments

miro_dietiker created an issue. See original summary.

sagar ramgade’s picture

sagar ramgade commented
Title: Fix Dropbutton uppercase first » Fix Operations select list options case on Admin Job overview
Status: Active » Needs review
StatusFileSize
new tmgmt-operations_case_fix-2583329-2-D8.patch4.08 KB

Please find the attached patch which fixes the operation case. Remember to clear the cache (views) in order to reflect the changes.

Status: Needs review » Needs work

The last submitted patch, 2: tmgmt-operations_case_fix-2583329-2-D8.patch, failed testing.

The last submitted patch, 2: tmgmt-operations_case_fix-2583329-2-D8.patch, failed testing.

juanse254’s picture

juanse254 commented

please reroll the patch (rebase) .

sagar ramgade’s picture

sagar ramgade commented

Tried with rebase, however the patch doesn't get created properly. I am windows machine not sure if that is the cause.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

I guess it does not appy anymore due to this issue #2577211: Set manage as default job action
So there are just additional weights.
These kind of merge conflicts need manual resolution. :-)

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-operations_case_fix-2583329-8.patch2.94 KB

okay rerolled.

Status: Needs review » Needs work

The last submitted patch, 8: tmgmt-operations_case_fix-2583329-8.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-operations_case_fix-2583329-10.patch3.12 KB

i forgot that one ;).

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.