When a specific Panels task's variants are being sorted, it can be hard to differentiate between the different items if their names are not verbose enough. In order to help differentiate between them, it would be useful to list their selection rules along with their names.

CommentFileSizeAuthor
#7 ctools-variant_sort_page-2582541-7.patch1.6 KBkepford
#2 ctools.png65.85 KBkepford
#2 ctools-variant_sort_page-2582541-2.patch1.7 KBkepford

Comments

DamienMcKenna created an issue. See original summary.

kepford’s picture

kepford commented
Status: Active » Needs work
StatusFileSize
new ctools-variant_sort_page-2582541-2.patch1.7 KB
new ctools.png65.85 KB

Initial pass at adding this feature. However this change is actually to the Ctools project and specifically Page manager 7.x-1.9. This change is producing a warning.

Warning: Creating default object from empty value in page_manager_handler_rearrange() (line 1557 of /docroot/sites/all/modules/contrib/ctools/page_manager/page_manager.admin.inc).

page-manager

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Project: Panels » Chaos Tool Suite (ctools)
Version: 7.x-3.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: ctools-variant_sort_page-2582541-2.patch, failed testing.

kepford queued 2: ctools-variant_sort_page-2582541-2.patch for re-testing.

The last submitted patch, 2: ctools-variant_sort_page-2582541-2.patch, failed testing.

kepford’s picture

kepford commented
Status: Needs work » Needs review
StatusFileSize
new ctools-variant_sort_page-2582541-7.patch1.6 KB

Warning resolved and rerolled to apply to 7.x-1.x-dev

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

This provides a reasonable UX improvement and uses CTools' own APIs to make the change, so there's little extra code involved.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good, tested good. Committed.

  • japerry committed 29c0c92 on 7.x-1.x authored by kepford 
    Issue #2582541 by kepford: Variant sort page should display the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.