We just upgraded from 7.x-4.0-beta2 to beta3, and we're receiving a fatal error:
Call to undefined function commerce_reports_reportable_order_states() in /sites/all/modules/commerce_reports/modules/tax/includes/views/commerce_reports_tax.views_default.inc on line 69
I just spent some more time looking at it, I think it happened because we had Tax Reports enabled, but didn't have the Reports module enabled. Partially our fault, but I think Tax Reports needs a dependency on Reports?
Thanks,
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | undefined_function_in-2582039-7.patch | 2.28 KB | dylf |
| #3 | commerce_reports-2582039-3-tax_depends_on_reports.patch | 701 bytes | xurizaemon |
Comments
Comment #2
mglamanMarking to major. The tax module never required main module as dependency, and I kind of liked that (I think more people use that than main reports.) Thanks for identifying this.
Comment #3
xurizaemonRan into this, here's a patch since I'm waiting for a deploy to complete.
This can bite you if you
drush dis commerce_reportsand Commerce Tax Reports starts to have baby fatals a lot.Comment #5
webadpro commentedPatch #3, worked for me also.
Comment #6
dsuess commentedthis update just took down my store. please address!
Comment #7
dylf commentedNot sure if this is the right approach but instead of adding a dependency I added a function that does the same thing in the commerce_reports_tax module.
Comment #8
dylf commentedComment #10
dylf commentedNot sure that the failing test is related to this issue.
Comment #11
mglamanRetested 5.5
Comment #12
splendidles commentedI can report that #3 works, I was able to replicate this one by disabling reports, flushing caches and then viewing the tax report. Provided that the reporter can ensure they did not have commerce_reports at the time, then that looks to be the issue. Patch #3 resolves this. Once commerce_reports is enabled again, the report works and I'm seeing no errors in the logs.
Comment #14
mglamanWorks good enough for me. No idea how to work around it otherwise. People often seem to use the tax submodule more than the normal module anyways.