Follow-up to #2577187: Check if authenticated or anonymous users have privileged access
When #2577187: Check if authenticated or anonymous users have privileged access is committed, we want to show a second list of users with privilege access to see relevant verbose information about users.
Create a new table with the list of users and merge it to the first table in the verbose output of the UserIntegriy Sensor.
The verbose output is going to show two tables.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | monitoring_2581701_user_verbose_13.patch | 7.83 KB | giancarlosotelo |
| #11 | monitoring_2581701_user_verbose_11REBASE.patch | 7.83 KB | giancarlosotelo |
| #9 | interdiff-7-9.txt | 1.33 KB | giancarlosotelo |
| #9 | monitoring_2581701_user_verbose_9.patch | 7.57 KB | giancarlosotelo |
| #7 | Screen Shot 2015-10-17 at 24.31.20 .png | 92.42 KB | miro_dietiker |
Comments
Comment #2
giancarlosotelo commentedHere is the first patch, note that it depends on #2577187: Check if authenticated or anonymous users have privileged access which is not yet committed but its fixed :P so patch is not going to apply
Screenshot attached. Which fields should I consider? then I will start working on tests.
Comment #4
giancarlosotelo commentedComment #5
miro_dietikerLooks pretty good.
I would prefer to have the preparation code and the output of the table beside each other: so first the changes (loop + output) and then the users (loop + output).
And yeah, we need tests. :-)
Comment #6
giancarlosotelo commentedChanged the code and added test for the second table.
Image attached with new fields on the table.
Comment #7
miro_dietikerI did some reordering of things and streamlined code and structure of output.
Splitted even the change table and changed column definitions.
There were some minor bugs such as you outputted created date for changed date, ...
Tests will not pass, please fix / rework them accordingly.
Comment #9
giancarlosotelo commentedFixed on test.
Comment #10
miro_dietikerPatch doesn't apply anymore... :-)
Comment #11
giancarlosotelo commentedI made a rebase, hope tests still pass.
Comment #13
giancarlosotelo commentedOk this is it.
Comment #14
miro_dietikerThx! Committed. :-)