showInLinks() currently returns back the view name it was passed in. I can see this was done for the ease of the form that calls it, but it's just weird DX.

CommentFileSizeAuthor
#2 2581507.flag_.showInLinks-return.patch1.18 KBjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
2581507.flag_.showInLinks-return.patch1.18 KB
socketwench’s picture

socketwench CreditAttribution: socketwench as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks good.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks for reviewing.

Committed!

  • joachim committed f20fd9c on 8.x-4.x 
    Issue #2581507 by joachim: Changed EntityFlagType::showInLinks() to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.