The term 'subtypes' is still dotted all over our code.

Some instances are to mean 'flag type'; some are 'bundles'.

CommentFileSizeAuthor
#2 2581503.flag_.subtypes-terminology.patch3.68 KBjoachim

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2581503.flag_.subtypes-terminology.patch3.68 KB
socketwench’s picture

socketwench commented
Status: Needs review » Reviewed & tested by the community

Didn't we already have a conversation about bundles vs. subtypes? We wanted to avoid terminology crossover with Symfony bundles...

Maybe it doesn't matter.

joachim’s picture

joachim commented

We did, but we ended up concluding that the entity bundles vs Symfony bundles clash is core's problem, and that since core is still using the term entity bundles, we should follow what core does because to invent our own thing in Flag would cause more confusion.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Committed.

Thanks for the review!

  • joachim committed 9c796cd on 8.x-4.x 
    Issue #2581503 by joachim: Cleaned up terminology around 'subtypes'/'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.